test(NODE-7534): add prose tests for retry behavior with mixed overload/non-overload errors#4921
Merged
PavelSafronov merged 6 commits intomainfrom Apr 24, 2026
Merged
test(NODE-7534): add prose tests for retry behavior with mixed overload/non-overload errors#4921PavelSafronov merged 6 commits intomainfrom
PavelSafronov merged 6 commits intomainfrom
Conversation
…-overload errors - Add 4 new prose tests per spec commit 7039e69 - Test 4 (reads/writes): Verify MAX_RETRIES applies to all errors after overload - Test 5 (reads/writes): Verify backoff only applies to overload errors - Uses mocking pattern consistent with existing prose tests
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new prose integration tests to validate the driver’s retry behavior when encountering an initial SystemOverloadedError followed by subsequent non-overload retryable errors, per the referenced spec guidance.
Changes:
- Add new retryable-writes prose cases to verify
MAX_RETRIESis honored across mixed overload/non-overload retryable write errors. - Add new retryable-reads prose cases to verify
MAX_RETRIESis honored across mixed overload/non-overload retryable read errors. - Add timing-based assertions (via
measureDuration) to ensure backoff is only applied to overload-labeled errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/integration/retryable-writes/retryable_writes.spec.prose.test.ts | Adds Case 4/5 prose tests for mixed overload/non-overload retry behavior and backoff timing for retryable writes. |
| test/integration/retryable-reads/retryable_reads.spec.prose.test.ts | Adds new prose suites to validate max-retry behavior and backoff timing for retryable reads under mixed error-label sequences. |
tadjik1
added
the
Primary Review
tadjik1
removed
Primary Review
PavelSafronov
added
the
Primary Review
PavelSafronov
previously approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new prose tests to validate retry/backoff behavior when an initial SystemOverloadedError is followed by retryable non-overload errors, aligning with the retryable reads/writes prose spec scenarios.
Changes:
- Add “Case 4” tests asserting
MAX_RETRIES + 1attempts occur even when later retryable errors are not overload errors (reads + writes). - Add “Case 5” tests intended to assert backoff is applied only for overload errors (reads + writes).
- Introduce
measureDurationusage to time retry sequences for the backoff assertions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/integration/retryable-writes/retryable_writes.spec.prose.test.ts |
Adds two new prose cases (max retries after overload; backoff only for overload) using Server.prototype.command stubbing + timing. |
test/integration/retryable-reads/retryable_reads.spec.prose.test.ts |
Adds two new prose describes for the same behaviors for reads, including new imports and per-describe client lifecycle hooks. |
dariakp
added
Team Review
nbbeeken
commented
Apr 22, 2026
Contributor
Author
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
LGTM on the changes
PavelSafronov
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
WIP
What is the motivation for this change?
Coverage reccomended by spec
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript